Xiao-zhen-Liu commented on code in PR #8770:
URL: https://github.com/apache/texera/pull/8770#discussion_r4199580183
##########
common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/udf/python/PythonUDFOpDescV2Spec.scala:
##########
@@ -304,4 +305,46 @@ class PythonUDFOpDescV2Spec extends AnyFlatSpec with
Matchers {
case other => fail(s"expected OpExecWithCode, got
$other")
}
}
+
+ private def defaultCode: String =
Review Comment:
`defaultCode`, `activeLines` and `uncommentClass` are copied into all three
specs (also `DualInputPortsPythonUDFOpDescV2Spec.scala` line 214 and
`PythonUDFSourceOpDescV2Spec.scala` line 164). Could they live in one test
helper that takes the descriptor class, so a fix to `uncommentClass` lands in
one place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
