aglinxinyuan opened a new pull request, #8924: URL: https://github.com/apache/texera/pull/8924
### What changes were proposed in this PR? Removes `WorkflowCoverService.getCover`, which no production code has called since covers started arriving on the search and list responses. It also drops the `of` / `catchError` / `map` imports that only `getCover` used. **+6/−31 lines.** There is no behaviour change. `setCoverFromFile` and `clearCover`, the service's live methods, stay. Spec changes: - **`workflow-cover.service.spec.ts`:** the two `getCover` cases are deleted. - **`card-item.component.spec.ts`:** the `getCover` mock member is dropped. The two "use the stored cover" / "fall back to the default image" cases keep their assertions. Their `expect(getCover).not.toHaveBeenCalled()` line was #6280's guard against a per-card cover fetch, so it is replaced with an HTTP-level `expectNone` on `/cover`. That keeps the guard without naming a method that no longer exists. - **`hub-search-result.component.spec.ts`:** the mock member is dropped. ### History | | | | --- | --- | | **Introduced by** | #5704 (2026-07-04), "feat(dashboard): add custom cover image for workflow cards". Each card called it to load its cover | | **Usage removed by** | #6280 (2026-07-13), "fix(workflow): include coverImage in search and list API responses". It fixed the N+1 fetch by putting the cover on the entry and deleted the card's call | It has been unused for nearly three months. ### Any related issues, documentation, discussions? Closes #8923 ### How was this PR tested? No new tests. #6280's no-per-card-fetch guard is kept, now as an HTTP-level assertion. From `frontend/`: - `npx ng test --watch=false --include='**/card-item.component.spec.ts' --include='**/workflow-cover.service.spec.ts' --include='**/hub-search-result.component.spec.ts'`: 3 files, 128 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -w "getCover" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
