Ma77Ball commented on issue #8728: URL: https://github.com/apache/texera/issues/8728#issuecomment-6132111330
@PG1204 - For question 1, I recommend sticking with throw, as it stores the error on the output port, which is the operator's built-in "operator not ready yet" path. This error-handling approach also gives the user a human-readable message rather than a null pointer exception. So please move all four to throw, matching the 6 existing operators and #7299 (require is fine too; it just throws IllegalArgumentException). - For question 2, I recommend sticking to one PR (assuming it is not massive >2000 lines of code) as it will help with the review process and confirm the contract is uniform. Stacked PRs are also tedious and take a lot of effort from both the reviewer and the developer (so I'd like to avoid that here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
