tanishqgandhi1908 opened a new pull request, #8965:
URL: https://github.com/apache/texera/pull/8965

   ### What changes were proposed in this PR?
   
   In list view, the Datasets and Models pages bound the results list’s 
(refresh) to ngAfterViewInit(), which only subscribed to the user stream again. 
The search it triggered saw the same filters and sort and returned early, so 
the list was never reloaded. After revoking your own access, the item stayed 
listed until a page reload, and each refresh added another subscription that 
was never removed.
   
   Both pages now bind (refresh)="search(true)", the forced search card view 
already uses.
   
   Before: after revoking your own access to sales-2026, it is still listed:
   
   <img width="1440" height="900" alt="before-2-revoke-own-access" 
src="https://github.com/user-attachments/assets/0bd7c55a-a538-43ca-885f-7935f877f67a";
 />
   
   <img width="1440" height="900" alt="before-3-row-still-listed" 
src="https://github.com/user-attachments/assets/7a1a79ad-99fb-4972-8ca3-2b97762c740d";
 />
   
   After: the item disappears right away on both pages:
   
   <img width="1440" height="900" alt="after-2-datasets-row-gone" 
src="https://github.com/user-attachments/assets/2be72235-895e-457f-ba8d-1d70092d5ce0";
 />
   
   <img width="1440" height="900" alt="after-4-models-row-gone" 
src="https://github.com/user-attachments/assets/749ff178-a843-4ce5-9087-2c91feecace8";
 />
   
   ### Any related issues, documentation, discussions?
   Closes #8964
   
   ### How was this PR tested?
   
   Added a case to each of user-dataset.component.spec.ts and 
user-model.component.spec.ts: a refresh from the results list runs a forced 
search. Both fail without the fix.
   
   cd frontend
   yarn ng test --watch=false --include='**/user-dataset.component.spec.ts' 
--include='**/user-model.component.spec.ts'
   Tests  65 passed (65)
   
   Also checked against a local stack: as a WRITE collaborator in list view, 
revoking your own access removes the dataset or model from the list on both 
pages.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to