Pinitsdv commented on PR #8628: URL: https://github.com/apache/texera/pull/8628#issuecomment-6153243898
Screenshots, as requested. Firefox on Windows 10, window 1366×768 at 70% zoom, commit b3c486d. To reproduce: start the stack with bin/local-dev.sh up, sign in, open any workflow, and type into the palette's search box. The queries below are the ones shown. 1 — A query phrased as an intent: remove repeated rows Distinct leads at 0.71, Limit follows at 0.52, and each result carries its own description. The current search returns nothing for this query. <img width="1366" height="729" alt="1 RESULTS" src="https://github.com/user-attachments/assets/bdc4c581-5868-47a9-b775-2d56c32303c5"; /> 2 — A query that names the operator: distinct Naming an operator still puts it first, which is the behaviour the keyword search already had. The entry without a score is a keyword match: only ranked results carry a similarity. <img width="1366" height="728" alt="DISTINCTS" src="https://github.com/user-attachments/assets/8ff669ab-20cf-441c-b169-715ae6605b13"; /> 3 — The first query of a browser session While the model downloads, the palette says so rather than looking broken. It is on screen for about three seconds on a normal connection. The Network panel in this shot also shows where the index comes from: operator-embeddings.json, an asset of the application itself, served from localhost — there is no API call behind a search. <img width="1366" height="462" alt="LOADING MODEL" src="https://github.com/user-attachments/assets/66b1dbee-6b81-40dd-821b-4511a069e513"; /> 4 — With no internet at all, and the model never downloaded The machine's network was switched off and a fresh private window opened, so the model could not be fetched or read from cache. Sort still answers: the keyword search is unaffected. None of the results carries a similarity score, which is exactly the ranker not having loaded — the fallback, visible. <img width="1251" height="768" alt="OFFLINE model not charged yet" src="https://github.com/user-attachments/assets/9ac80a4e-73e8-47e6-a1db-35d88b71de2f"; /> This is the case worth looking at for the air-gapped question raised in the PR description: the feature degrades to today's behaviour instead of breaking, so an instance with no route to the CDN keeps a working palette. We are still glad to self-host the model and the WASM under assets/ if that is the direction you prefer. On the before/after pairing you asked for: shot 4 is effectively the "before" for a query that names an operator — with the ranker unavailable, the palette behaves exactly as main does today, and Sort is answered the same way. For a query phrased as an intent there is no "before" image worth showing: on main, remove repeated rows returns an empty list, which is also the 2/166 top-three figure in the measurement above. If a screenshot of that empty list would still be useful next to shot 1, say so and we will add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
