Xiao-zhen-Liu commented on code in PR #8932:
URL: https://github.com/apache/texera/pull/8932#discussion_r4263187707
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts:
##########
@@ -195,6 +197,7 @@ export class UserDatasetFileRendererComponent implements
OnInit, OnChanges, OnDe
}
reloadFileContent() {
+ this.fileLoad?.unsubscribe();
Review Comment:
This cancels a file that is still downloading, but not one that is still
being parsed: `readXlsxFile`, `Papa.parse` and `readFileAsText` finish later
and still write their result. For example, clicking a large CSV and then a
small one can leave the large file's rows under the small file's name. These
callbacks should check that their file is still the selected one before writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
