Copilot commented on code in PR #8997: URL: https://github.com/apache/texera/pull/8997#discussion_r4284989432
########## LICENSE: ########## @@ -275,6 +278,18 @@ build: Source: https://github.com/yarnpkg/berry License: BSD 2-Clause License (licenses-3rd-party-code/yarn.txt) +BSD 3-Clause License +-------------------------------------- + +This product includes the Project Jupyter logo, drawn into a diagram: + - frontend/src/assets/notebook_migration_tool/tool_popup_diagram.png + Copyright (c) 2014, Project Jupyter + Source: https://github.com/jupyter/design + License: BSD 3-Clause License (licenses/LICENSE-BSD-3-Clause.txt) Review Comment: This section introduces a BSD 3-Clause-licensed asset but only points to a generic BSD 3-Clause text file. For compliance/auditability, it should also include (or point to) the specific copyright/license notice required by the upstream project (often a project-specific BSD 3-Clause header), not just the generic license template. Consider adding the exact upstream notice text (or referencing a repo-local third-party notice file that contains it) so that the attribution is complete and verifiable. ########## LICENSE: ########## @@ -243,8 +243,11 @@ This product bundles the ScalaPB options definition: Source: https://github.com/scalapb/ScalaPB License: Apache License 2.0 (this LICENSE file) -This product includes an icon from Google's Material Symbols: +This product includes icons from Google's Material Symbols: - frontend/src/app/common/icon/model-icon.ts ("hub") + - the "psychology", "smart_toy" and "snippet_folder" icons drawn into + frontend/src/assets/notebook_migration_tool/tool_popup_diagram.png, + python_file_diagram.png and python_folder_diagram.png Review Comment: The updated Material Symbols entry mixes a code reference (TypeScript icon name) with asset references (PNG diagrams), but it doesn’t specify whether the diagram icons are redistributed as rasterized derivatives or as original SVG paths. For license clarity/auditability, consider adding a short clarifier (e.g., that the symbols are incorporated/embedded into the PNG diagrams) and ensure the referenced filenames are consistently formatted (either all as quoted paths or all as bullet paths) to avoid ambiguity during license scanning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
