mengw15 opened a new issue, #9012:
URL: https://github.com/apache/texera/issues/9012
`bin/frontend-proto-gen.sh` runs `protoc` over `workflow.proto` and
`virtualidentity.proto`. `protoc` also emits TypeScript for every transitive
dependency, so two more files land in the tree and are committed:
```
frontend/src/app/common/type/proto/google/protobuf/descriptor.ts 6824 lines
frontend/src/app/common/type/proto/scalapb/scalapb.ts 2394 lines
```
Nothing imports either of them. `workflow.ts` imports only
`@bufbuild/protobuf/wire` and `./virtualidentity`; `virtualidentity.ts`
imports
only `@bufbuild/protobuf/wire`. The sole importer of `descriptor.ts` is
`scalapb.ts` itself, and `scalapb.ts` has no importer anywhere under
`frontend/src` (the one other `scalapb` match is a comment in
`workflow-common.interface.ts`). There is no `index.ts` re-exporting them.
They are generated but unreachable because `workflow.proto` uses
`scalapb/scalapb.proto` only for options:
```proto
option (scalapb.options) = { ... };
PhysicalOpIdentity opId = 1 [(scalapb.field).no_box = true];
```
`scalapb.options` and `scalapb.field` are extensions read by the ScalaPB
generator to shape the Scala output. They produce no TypeScript types, so the
generated `workflow.ts` never needs `scalapb.ts`.
Proposed change: have `bin/frontend-proto-gen.sh` remove the two surplus
output
trees (`proto/scalapb` and `proto/google`) after `protoc` runs, and delete
the
committed files. Deleting them without changing the script would only have
them
reappear on the next regeneration.
Side effect: the two `LICENSE` entries added for these files (#8802) can be
dropped in the same change, since the files would no longer be bundled.
Sequencing: the `LICENSE` entries should land first — they clear a release
blocker — and this cleanup is a separate change that needs its own
verification
(regenerate, build the frontend, run the frontend tests).
Generated-by: Claude Code (claude-opus-5-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
