aglinxinyuan opened a new issue, #9026:
URL: https://github.com/apache/texera/issues/9026

   ### Task Summary
   
   `WorkerTimerService` (`amber/.../messaginglayer/WorkerTimerService.scala`) 
keeps an `isPaused` flag that only `pauseAdaptiveBatching()` sets to true. 
Nothing in production calls `pauseAdaptiveBatching()`, so `isPaused` is always 
false, and `resumeAdaptiveBatching()` (called from the worker `ResumeHandler`) 
never re-arms anything.
   
   **Introduced by** #1826 (2023-02-02, "Add time-based batch in network output 
buffer"), which added the pause method. #2208 (2023-11-16, "Refactoring of 
amber engine") moved it into `WorkerTimerService` and added `isPaused`, 
`resumeAdaptiveBatching()` and the `ResumeHandler` call.
   
   **Usage removed by** #2392 (2024-02-19, "Remove breakpoint feature"), which 
deleted the last caller of `pauseAdaptiveBatching()`, the breakpoint branch in 
`DataProcessor`.
   
   Removing the two methods, the flag and the no-op `ResumeHandler` call is a 
pure deletion with no behaviour change.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to