yangzhang75 commented on PR #9022: URL: https://github.com/apache/texera/pull/9022#issuecomment-6261884060
Closing this rather than asking for review time on it. The binding is wrong in shape, but the hazard it leaves is not reachable: this page holds an open WebSocket (the shared-document `/rtc/…` connection it opens to load the workflow), and Chrome keeps a page with one out of the back/forward cache. Measured on main with the cache explicitly enabled, headless and headed: navigate away from the detail page and back, `pageshow.persisted` is `false`, and the preview comes back from a fresh load with the workflow drawn. Nothing for a reader to meet, so nothing to fix now. The branch stays on the fork if the page ever stops holding that connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
