bobbai00 commented on code in PR #8071:
URL: https://github.com/apache/texera/pull/8071#discussion_r4319074248
##########
.github/release/vote-email-template.txt:
##########
@@ -0,0 +1,61 @@
+Subject: [VOTE] Release Apache Texera (incubating) ${VERSION} RC${RC_NUM}
+
+Hi Texera Community,
+
+This is a call for a vote on releasing Apache Texera (incubating) ${VERSION}
RC${RC_NUM}.
+
+== Release Candidate Artifacts ==
+
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
+
+The staging directory contains the source tarball and the Docker Compose
convenience bundle, each with its GPG signature (.asc) and SHA-512 checksum
(.sha512).
+
+== Container Images ==
+
+The convenience container images pulled by the bundled Docker Compose file:
+
+${IMAGE_LIST}
+
+== Git Tag and Commit ==
+
+https://github.com/apache/texera/releases/tag/${TAG_NAME}
+
+Commit: ${COMMIT_HASH}
Review Comment:
**Must fix:**
This renders the annotated tag object, not the commit. `COMMIT_HASH` is `git
rev-parse "$TAG_NAME"` (`create-release-candidate.yml:102-103`), and every RC
tag since 1.2.0 is annotated. [Run
30597990997](https://github.com/apache/texera/actions/runs/30597990997) logged
`e7305289c` for `v1.2.0-incubating-rc4`. The [email that went
out](https://lists.apache.org/thread/fyz6nmx27fcw49wchxy0ornjgc2glkzy) says
`c3aa6e4ba`, its commit. Peeling to the commit fixes it and makes the default
`IMAGE_TAG` match `build-and-push-images.yml:96`. (Both real runs used
`use_tag_as_image_tag=true`, relevant to `:458`.)
```bash
COMMIT_HASH=$(git rev-parse "${TAG_NAME}^{commit}")
COMMIT_SHORT=$(git rev-parse "${TAG_NAME}^{commit}" | cut -c1-9)
```
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -432,7 +455,7 @@ jobs:
echo "Each artifact has a corresponding \`.asc\` (GPG signature) and
\`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
- echo "1. Build and push container images using the \`Build and push
images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
+ echo "1. Build and push container images using the \`Build and push
images\` workflow with tag \`${IMAGE_TAG}\` (the tag the bundled .env pins)" >>
$GITHUB_STEP_SUMMARY
Review Comment:
**Advisory:**
Should this also name the ref to build from? `Build and push images`
defaults `branch` to `main` (`build-and-push-images.yml:26`), so following this
line as written builds main's HEAD and tags it as the RC. If the release
runbook already covers it, feel free to ignore.
```suggestion
echo "1. Build and push container images using the \`Build and
push images\` workflow with branch \`${TAG_NAME}\` and tag \`${IMAGE_TAG}\`
(the tag the bundled .env pins)" >> $GITHUB_STEP_SUMMARY
```
##########
.github/release/vote-email-template.txt:
##########
@@ -0,0 +1,61 @@
+Subject: [VOTE] Release Apache Texera (incubating) ${VERSION} RC${RC_NUM}
Review Comment:
**Advisory:**
This drops the ASF header the `.md` carried, and `.licenserc.yaml` skips
`**/*.txt`. The [ASF
FAQ](https://www.apache.org/legal/src-headers.html#faq-exceptions) exempts
short informational files like README but says to "err on having a source
header". These 61 lines of prose ship in the tarball whose checklist (`:51`)
asks for headers. Could the header stay as `#` lines, stripped by `grep -v
'^#'` in place of the `cp` at `create-release-candidate.yml:287`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
