Yicong-Huang commented on code in PR #6009:
URL: https://github.com/apache/texera/pull/6009#discussion_r4344464628
##########
frontend/src/app/workspace/service/agent/agent.service.ts:
##########
@@ -1224,36 +1252,32 @@ export class AgentService {
// Operator Result Annotation Methods
//
============================================================================
- /** Current operator result summaries (operatorId → summary) */
- private operatorResultSummariesSubject = new BehaviorSubject<Map<string,
OperatorResultSummary>>(new Map());
- public operatorResultSummaries$ =
this.operatorResultSummariesSubject.asObservable();
+ /** Current operator execution summaries (operatorId -> summary) */
+ private operatorExecutionSummariesSubject = new BehaviorSubject<Map<string,
OperatorExecutionSummary>>(new Map());
+ public operatorExecutionSummaries$ =
this.operatorExecutionSummariesSubject.asObservable();
/**
- * Update operator result summaries from an API response.
+ * Update operator execution summaries from an API response.
*/
- private updateOperatorResultSummaries(results: Record<string,
OperatorResultSummary>): void {
- const summaries = new Map<string, OperatorResultSummary>();
- for (const [opId, data] of Object.entries(results)) {
- summaries.set(opId, data);
- }
- this.operatorResultSummariesSubject.next(summaries);
+ private updateOperatorExecutionSummaries(results: Record<string,
OperatorExecutionSummary>): void {
+ this.operatorExecutionSummariesSubject.next(new
Map(Object.entries(results)));
}
/**
* Pull the agent's latest operator result summaries from the backend and
push
Review Comment:
**Polish:**
The `fetchOperatorResults` TSDoc still says "operator result summaries"
while this PR renames the stream to `operatorExecutionSummaries$` and the
sibling docs at :1255 and :1260 say "operator execution summaries". The term is
stale relative to the PR's own rename. Consider changing the first sentence to
"Pull the agent's latest operator execution summaries from the backend and
push".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
