kunwp1 commented on code in PR #8986:
URL: https://github.com/apache/texera/pull/8986#discussion_r4370007023
##########
bin/k8s/templates/base/workflow-computing-unit-manager/workflow-computing-unit-manager-service-account.yaml:
##########
@@ -63,3 +63,30 @@ roleRef:
kind: Role
name: {{ .Values.workflowComputingUnitManager.name }}
apiGroup: rbac.authorization.k8s.io
+
+---
+# Read-only and cluster-wide for the admin cluster-capacity endpoint: nodes
are cluster-scoped and
+# every namespace's pods take their capacity, so the namespaced Role above
cannot cover it.
+# Named for the release because a ClusterRole is cluster-scoped.
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+ name: {{ .Release.Name }}-{{ .Values.workflowComputingUnitManager.name
}}-cluster-capacity
Review Comment:
Thank you for the comments! I applied the suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
