emmenlau commented on pull request #2051: URL: https://github.com/apache/thrift/pull/2051#issuecomment-621972514
I think something else must be wrong. This PR should not be required. See in https://github.com/apache/thrift/blob/dd63da19fad25ff8379f9505e626b16f45593e57/build/cmake/DefineCMakeDefaults.cmake#L66 there is c++11 enabled on all platforms. And its even respecting that you can overwrite the version from the command line, for example using: ``` cmake -DCMAKE_CXX_STANDARD=17 ... other options ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
