dugenkui03 commented on a change in pull request #2125:
URL: https://github.com/apache/thrift/pull/2125#discussion_r428821954
##########
File path: lib/java/src/org/apache/thrift/utils/StringUtils.java
##########
@@ -49,12 +49,10 @@ public static String bytesToHexString(byte[] bytes) {
* @return hex string.
*/
public static String bytesToHexString(byte[] bytes, int offset, int length) {
- if (length < 0) {
- throw new IllegalArgumentException("Negative length " + length);
- }
- if (offset < 0) {
- throw new IndexOutOfBoundsException("Negative start offset " + offset);
+ if ((offset | length | (offset + length) | (bytes.length - (offset +
length))) < 0) {
Review comment:
it seem that there will always be readability problem when using bit
operation.
I do agree with that the readability of code is important. The code will be
changed and squashed to a single commit.
Thanks very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
