ulidtko commented on pull request #2151:
URL: https://github.com/apache/thrift/pull/2151#issuecomment-632290124
Linux CI got green. Appveyor though...
```
C:\projects\thrift\lib\cpp\src\thrift/transport/TSocketUtils.h(99): error
C2440: 'return': cannot convert from 'WCHAR *' to
'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
(compiling source file
C:\projects\thrift\lib\cpp\src\thrift\transport\TServerSocket.cpp)
[C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
C:\projects\thrift\lib\cpp\src\thrift/transport/TSocketUtils.h(99): note:
No constructor could take the source type, or constructor overload resolution
was ambiguous (compiling source file
C:\projects\thrift\lib\cpp\src\thrift\transport\TServerSocket.cpp)
C:\projects\thrift\lib\cpp\src\thrift/transport/TSocketUtils.h(122): error
C2065: 'EAI_SYSTEM': undeclared identifier (compiling source file
C:\projects\thrift\lib\cpp\src\thrift\transport\TServerSocket.cpp)
[C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
```
That's what I got here, with the relevant code:
```c++
virtual std::string message(int code) const override {
return THRIFT_GAI_STRERROR(code);
}
```
```c++
# ifdef _WIN32_WCE
# define THRIFT_GAI_STRERROR(...)
thrift_wstr2str(gai_strerrorW(__VA_ARGS__))
# else
# define THRIFT_GAI_STRERROR gai_strerrorA
# endif
```
Jeez, what a mess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
