emmenlau commented on pull request #2121: URL: https://github.com/apache/thrift/pull/2121#issuecomment-632360470
Actually I've also seen this too late. The definition of 'htonll' breaks the build for me on VS2017 and VS2019 when building Thrift TestServer.cpp: ``` thrift\lib\cpp\src\thrift/transport/TWebSocketServer.h(366): error C3861: 'htonll': identifier not found ``` I've tried a number of things to work around this issue but as far as I can see its not trivial. I've moved a number of `Windows.h` includes out of the way which supposedly break including `WinSock2.h`, but that did not help. Defining `WIN32_LEAN_AND_MEAN` globally also did not resolve the problem. And shuffling the headers to that `TWebSocketServer.h` comes first also does not help. So I'm at the end of my wit, suggestions welcome. Also, did you see that `TProtocol.h` has a defintion of `THRIFT_htonll`? Could that be used instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
