Jens-G edited a comment on pull request #2121: URL: https://github.com/apache/thrift/pull/2121#issuecomment-632394608
> Could that be used instead? I had the same thoughs ... we have code for it. Shouldn't that be sufficient? > the definition of 'htonll' breaks the build for me Actually, on the Github page of said header, someone also commented that MSVC seems not really good covered by it, at least this was the case in 2018. https://gist.github.com/panzi/6856583#gistcomment-2396000 > Otherwise an addition to LICENSE seems appropriate. I did that a few minutes ago. If we are going to remove the file, please also remove my additions from LICENSE . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
