emmenlau commented on a change in pull request #2148:
URL: https://github.com/apache/thrift/pull/2148#discussion_r429913452
##########
File path: lib/cpp/libthrift.vcxproj
##########
@@ -134,45 +182,53 @@
<ConfigurationType>StaticLibrary</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<CharacterSet>MultiByte</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review comment:
Dear @zeshuai007 This was my suggestion to remove it an let Visual
Studio automatically add it for the developer. But I understand you said this
did not build correctly? Can you clarify if it can safely be removed or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
