emmenlau commented on a change in pull request #2151: URL: https://github.com/apache/thrift/pull/2151#discussion_r431677460
########## File path: lib/cpp/src/thrift/transport/TSocketUtils.h ########## @@ -0,0 +1,185 @@ +/* + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + * Copyright (c) 2020 Max Ivanov <[email protected]> + */ Review comment: > You sure about this? I see plenty, on the order of thousands. Not to take any sides here, but I think the github search may be misleading. If you search the individual files, and remove irrelevant matches, it may look different. Here is an unrepresentative naiive search that I just did: ``` #> grep -Iirn "copyright" *|grep -v "node_modules\|regarding copyright ownership\|LICENSE\|Apache-License\|jQuery\|Google\|doc/licenses\|AssemblyCopyright\|The Apache Software Foundation\|aclocal\|debian/copyright\|debian/README.md\|gradlew\|build/cmake" ``` This returns ``` bda-build-project.sh:7:# Copyright (c) BioDataAnalysis GmbH. All Rights Reserved. compiler/cpp/src/thrift/generate/t_cl_generator.cc:2: * Copyright (c) 2008- Patrick Collison <[email protected]> compiler/cpp/src/thrift/generate/t_cl_generator.cc:3: * Copyright (c) 2006- Facebook compiler/cpp/src/thrift/generate/t_html_generator.h:5: " * Copyright 2012 Twitter, Inc\n" \ compiler/cpp/tests/catch/catch.hpp:6: * Copyright (c) 2012 Two Blue Cubes Ltd. All rights reserved. contrib/fb303/acinclude.m4:1:dnl Copyright (C) 2009 Facebook contrib/fb303/acinclude.m4:3:dnl are permitted in any medium without royalty provided the copyright debian/changelog:54: * update copyright file doc/specs/thrift.tex:17:\documentclass[nocopyrightspace,blockstyle]{sigplanconf} doc/specs/thrift.tex:27:% \copyrightyear{2007} doc/specs/thrift.tex:28:% \copyrightdata{[to be supplied]} lib/delphi/test/keywords/ReservedKeywords.dproj:95: <VersionInfoKeys Name="LegalCopyright"/> lib/py/compat/win32/stdint.h:4:// Copyright (c) 2006-2008 Alexander Chemeris lib/py/compat/win32/stdint.h:9:// 1. Redistributions of source code must retain the above copyright notice, lib/py/compat/win32/stdint.h:12:// 2. Redistributions in binary form must reproduce the above copyright lib/cpp/src/thrift/windows/SocketPair.cpp:2: * Copyright 2007 by Nathan C. Myers <[email protected]>; some rights reserved. lib/cpp/src/thrift/windows/SocketPair.cpp:6: * this copyright notice must be retained, unchanged, in its entirety. If lib/php/src/ext/thrift_protocol/config.m4:1:dnl Copyright (C) 2009 Facebook lib/php/src/ext/thrift_protocol/config.m4:3:dnl are permitted in any medium without royalty provided the copyright lib/js/test/build/js/lib/Int64.js:2048:// Copyright (c) 2012 Robert Kieffer lib/js/test/build/js/lib/Int64Util.js:2143:// Copyright (c) 2012 Robert Kieffer lib/js/test/build/js/lib/JSONInt64.js:2959:// Copyright (c) 2012 Robert Kieffer ``` Of course I have no idea how to do this correctly, so very likely I'm ignoring too much... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
