emmenlau commented on a change in pull request #2151: URL: https://github.com/apache/thrift/pull/2151#discussion_r431935053
########## File path: lib/cpp/src/thrift/transport/TSocketUtils.h ########## @@ -0,0 +1,185 @@ +/* + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + * Copyright (c) 2020 Max Ivanov <[email protected]> + */ Review comment: Lets not get too hung up on this. @ulidtko I'm not a core team member but I do have a slight concern about the copyright that may or may not help to progress with this question. > This doesn't make sense to me; this line here basically says "I wrote this file" (which is true); the same line in top-level NOTICE would say "I wrote the whole Apache Thrift" (which is blatantly not true). So, a very bad refactoring, that would be. I've several times had the opposite problem to yours. I made a small (but I felt relevant) contribution to a larger code file from somebody else. If such a code file had an `authors` list or a `copyright` notice, this brought a dilemma with itself: Should I add myself to the header for my small change, or should I go unnoticed? Going unnoticed feels wrong, but having to maintain long authors lists for every code file equally so. While I do not mean to impose anything, and I'm not a Thrift member, I can see good reason for a single list of authors that contributed to the project. For anyone curious, git blame easily allows to see this in more detail for individual files (and many tools like Visual Studio show this automatically on a line-by-line base). Does that change anything for you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
