Jens-G commented on a change in pull request #2151: URL: https://github.com/apache/thrift/pull/2151#discussion_r431631203
########## File path: lib/cpp/src/thrift/transport/TSocketUtils.h ########## @@ -0,0 +1,185 @@ +/* + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + * Copyright (c) 2020 Max Ivanov <[email protected]> + */ Review comment: All correct, but we usually don't have **copyright notices** like in **line 21** in single files. http://www.apache.org/legal/src-headers.html#headers > SOURCE FILE HEADERS FOR CODE DEVELOPED AT THE ASF > > This section refers only to works submitted directly to the ASF by the copyright owner or owner's agent. If the source file is submitted with a copyright notice included in it, the copyright owner (or owner's agent) must either: > > * remove such notices, or > * move them to the NOTICE file associated with each applicable project release, or > * provide written permission for the ASF to make such removal or relocation of the notices. > > Each source file should include the following license header -- **note that there should be no copyright notice in the header**: > > Licensed to the Apache Software Foundation (ASF) under one > or more contributor license agreements. See the NOTICE file > distributed with this work for additional information > regarding copyright ownership. The ASF licenses this file > to you under the Apache License, Version 2.0 (the > "License"); you may not use this file except in compliance > with the License. You may obtain a copy of the License at > > http://www.apache.org/licenses/LICENSE-2.0 > > Unless required by applicable law or agreed to in writing, > software distributed under the License is distributed on an > "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > KIND, either express or implied. See the License for the > specific language governing permissions and limitations > under the License. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
