Breakwell commented on a change in pull request #2083:
URL: https://github.com/apache/thrift/pull/2083#discussion_r432407811
##########
File path: lib/cpp/src/thrift/transport/TPipeServer.cpp
##########
@@ -400,13 +395,12 @@ bool TAnonPipeServer::createAnonPipe() {
SECURITY_ATTRIBUTES sa;
SECURITY_DESCRIPTOR sd; // security information for pipes
- if (!InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION))
- {
- GlobalOutput.perror("TPipeServer InitializeSecurityDescriptor (anon)
failed, GLE=", GetLastError());
+ if (!InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION)) {
+ GlobalOutput.perror("TPipeServer InitializeSecurityDescriptor (anon)
failed, GLE=",
+ GetLastError());
return false;
}
- if (!SetSecurityDescriptorDacl(&sd, true, NULL, false))
- {
+ if (!SetSecurityDescriptorDacl(&sd, true, NULL, false)) {
Review comment:
This is now inline with the clang format file in the repo. As it's a
step in the right direction and doesn't make the PR unclear I think it's fine
to leave the formatting change as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
