kainjow commented on a change in pull request #2127:
URL: https://github.com/apache/thrift/pull/2127#discussion_r432874729
##########
File path: lib/cpp/src/thrift/transport/TSocket.cpp
##########
@@ -792,6 +789,13 @@ void TSocket::setKeepAlive(bool keepAlive) {
return;
}
+#ifdef _WIN32
+ if (!path_.empty()) {
+ // Windows Domain sockets do not support SO_KEEPALIVE.
Review comment:
should this be a config.h setting instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
