fishy commented on pull request #2176: URL: https://github.com/apache/thrift/pull/2176#issuecomment-641413250
I also added more comment on `socketConn.IsOpen` to explicitly call out the side-effect (I thought I pushed that last night, but apparently I forgot to do `git commit` before `git push` so push did nothing 😬) In most cases there shouldn't be anything between `pushDeadline` and actual `Read`, as the whole purpose of doing `pushDeadline` is to set the deadline used by the `Read`. But I just added the comment there in case in the future someone tries to do something without realizing the side-effect. I agree that is not ideal but I don't know if there's any better solutions here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
