dcelasun commented on pull request #2190: URL: https://github.com/apache/thrift/pull/2190#issuecomment-652291550
Not so sure about this one: - We are spawning multiple additional goroutines per incoming request (the one you added and the one internal to the ticker). - Ticker is set to 1ms, which seems like it would cause a lot of scheduling overhead at runtime. I vaguely remember Go having some optimization for short timers, but I'm not sure. Did you test this on a production workload by any chance? I'd be especially interested to see its effects on latency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
