fishy commented on pull request #2190: URL: https://github.com/apache/thrift/pull/2190#issuecomment-652550901
Now bcae3bb (old) vs. this PR (new) has been running for 2hr+, here are the 2hr charts (still, cyan is new and green is old). Service A goroutines:  Service B goroutines:  Service A server side latency p50:  Service A server side latency p99:  Service B server side latency p50:  Service B server side latency p99 (this one is weird, the old one actually hits the timeout/40ms a lot, probably just bad luck?):  A->B client side latency p50:  A->B client side latency p99 (note that it's not always old A hitting old B and new A hitting new B. service A and B are both in their pool so any A->B request can hit any B service with a roughly equal chance):  The most notable gap is on B server side p50 latency, which could be as large as 1ms (it could be calculated as ~50% increase in latency, depending on how you calculate that). I think we can just document that (probably in `lib/go/README.md`?), and also document how to disable this feature if that 1ms is important to people there? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
