emmenlau commented on pull request #2157: URL: https://github.com/apache/thrift/pull/2157#issuecomment-667860669
This seems like a valuable change. And while I'm not any expert in JS, it looks sufficiently small to raise at least some trust, i.e. it mostly adds new behavior for the binary use case that was not handled before. The critical change seems to be: https://github.com/apache/thrift/pull/2157/files#diff-29759a12f6599c6aeca4c0ae88af5291R116 Could someone test it, or should me merge it on best trust and wait for user feedback? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
