ulidtko commented on a change in pull request #2160:
URL: https://github.com/apache/thrift/pull/2160#discussion_r465970045
##########
File path: lib/php/lib/Transport/TSocket.php
##########
@@ -251,8 +251,8 @@ public function open()
}
if (function_exists('socket_import_stream') &&
function_exists('socket_set_option')) {
- $socket = socket_import_stream($this->handle_);
- socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
+ $socket = @socket_import_stream($this->handle_);
+ @socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
}
Review comment:
I don't think this patch fixes anything. The [`@` operator in PHP][•],
apparently, just silences errors.
However, it remedies the SSL warnings burden for (some of) the consumers of
Thrift PHP library.
Please at least add a comment saying ` // warnings silenced due to bug
https://bugs.php.net/bug.php?id=70939` @sveneld
[•]: https://stackoverflow.com/q/1032161/531179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
