ulidtko commented on pull request #2160: URL: https://github.com/apache/thrift/pull/2160#issuecomment-669892204
> Thanks. What else is need for merging this pull request? @Jens-G action. Ideally, you need to get the CI to become green, too. Unfortunately Thrift's test suites aren't as stable, so you get unrelated test failures on Travis like this: ``` =============================================================================== *** Following 6 failures were unexpected ***: If it is introduced by you, please fix it before submitting the code. =============================================================================== server-client: protocol: transport: result: java-erl multi-binary fastframed-framed-ip-ssl failure(1) java-erl multi-binary buffered-ip-ssl failure(1) java-erl multi-binary framed-ip-ssl failure(1) java-erl binary fastframed-framed-ip-ssl failure(1) java-erl binary buffered-ip-ssl failure(1) java-erl binary framed-ip-ssl failure(1) =============================================================================== ``` I don't think this PR should do anything to address that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
