deiv commented on pull request #2235: URL: https://github.com/apache/thrift/pull/2235#issuecomment-689614277
@ulidtko The other way to do it, is calculating the len of the string based on the type of socket: pathname socket: null terminated abstract socket: not null terminated This lead to an if in some point of the code. I prefer to do an aritmethic operation instead of adding a conditional jump (for a cpu point of view, the arithmethic way will not lead to control hazards). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
