ulidtko commented on pull request #2235:
URL: https://github.com/apache/thrift/pull/2235#issuecomment-689620808
OK, so we have:
* pathname socket — `'\0'` is last
* abstract socket — `'\0'` is first
The `.sun_path` length is `path_.size() + 1` in both cases. This needs no
`if`-s...
I mean: the `structlen -= …` line is bad, one needs to think really hard to
understand it completely. While the PR needs to change it anyway — why not
improve it? The `+ 1` you're adding does fix *the issue*, but makes *the code*
worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
