emmenlau commented on pull request #2235: URL: https://github.com/apache/thrift/pull/2235#issuecomment-689723230
> Make a unique function call for the 3 files, could be good too ... :) This is actually a subset of a larger section of TServerSocket.cpp and TSocket.cpp that mostly overlaps. For maintenance this would much better be unified. I don't have too much spare time, anyone wants to give it a go? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org