Jens-G edited a comment on pull request #2238: URL: https://github.com/apache/thrift/pull/2238#issuecomment-695812257
If I get it right, what you do here is to add the getters/setters but leave the fields publicly accessible? My idea was that you could add an option to the php generator that controls the new way using getters/setters and private fields, and if not set it would just generate the same code as before. Sorry for being not clear enough. Search for THRIFT_REGISTER_GENERATOR macro at the end of the file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
