deiv commented on pull request #2235: URL: https://github.com/apache/thrift/pull/2235#issuecomment-696030777
@zeshuai007 Fixed, seems that thrift is not ready for compiling unix sockets under windows. I just added some conditional macros. I fixed too, a variable that does not has the correct name (`is_abstract_namespace`) I added a TODO, to take into account, that windows has support to unix sockets, but the code is not prepared for that. At least it needs to include the windows headers for unix sockets. See [af_unix-comes-to-windows](https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/) I don't have a windows development enviroment, so I can't take a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
