fishy commented on pull request #2256: URL: https://github.com/apache/thrift/pull/2256#issuecomment-705140409
2ms it's ~13% and 3ms it's ~9%. Also all these tests are done on go1.15.2 on linux/amd64. I think around 10% cpu might still be too high as the default value. I think if we decided to not disable it by default, then the default value should be something like 5ms or 10ms, so that it doesn't auto add too much overhead, and still being useful for the majority of cases. For services with very low latency endpoints (like yours), they just need to change the default value, either: 1. Disable it (set it to 0) if they don't want those excessive cpu usage or 2. Set it to a smaller number (1ms/2ms/3ms) to balance between the extra cpu usage and able to abandon requests early when it's no longer needed. I think even for a 5ms p50 service, the 5ms default value can still be helpful for the long tails? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
