voodoo-dn commented on pull request #1992:
URL: https://github.com/apache/thrift/pull/1992#issuecomment-705808524
> So yeah, I think the cost of this change is way too high to avoid those 2
lines of code.
I think better to say: 2 line on code in 100 places.
Your middleware cannot log information, haven't information about which
handler method was called.
If you want take data from request and you protocol is Binary, you should
copy values from `in TProtocol` and deserialize data, lol, very efficient when
do it twice.
For metrics - the same, you do not know which handler method was called, you
know only **service name**.
**How you will collect metrics without handler method name?**
But I can answer instead of you: you can't do it at all.
How do you collect traces/metrics in real project? Where your jaeger span
starts and how you take "serviceName:methodName" to collect metrics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
