fishy commented on pull request #1992: URL: https://github.com/apache/thrift/pull/1992#issuecomment-706334453
> > > > It works for any TProtocol. > > > > > > > > > I meant: can I receive human readable data from TBinaryProtocol and log it? > > > > > > No. For human readable data you should use TSimpleJSONProtocol or TJSONProtocol. > > Are you think that is ok approach?) What do you mean? In my personal opinion json logging all requests and responses are very inefficient and not ok (I tried that `loggingMiddleware` in our staging, and because our requests and responses are so large our log ingester cannot handle those super large log entries). But it's as ok as your implementation of json marshal all requests and responses with interceptor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
