zerosnake0 commented on pull request #2190: URL: https://github.com/apache/thrift/pull/2190#issuecomment-722295740
Although this is a very demanding feature in my POV, but i think there is some problem in this PR 1. This feature should not be enabled by default for backward compatibility 2. The ticker loop design consumes too much cpu which is not good (which mentioned also by @dcelasun ) 3. The functionality should be encapsulated inside the transport interface I will make a new PR for this in some days ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
