zerosnake0 edited a comment on pull request #2181: URL: https://github.com/apache/thrift/pull/2181#issuecomment-722928987
> > I suggest you take a look at the golang official net/http implementation before any furthur discussion > > If I may, "go read net/http" is not a productive attitude. You are arguing against a change that was already discussed, agreed to and merged. That's fine, it's even welcome. But the onus is on _you_ to convince us there is a better way and that we should revert this. You didn't even address @fishy's first and second point. I surely read the first point and I agree with the "rarer implementation point" so I said nothing. Same for the 3rd point. And why i mentioned net/http because there is something similar for this kind of issue and I'm not sure if you know it. You quote my phrase in just three word "go read net/http" when I typed such a long phrase. I apologize if there is any word misusage. What's more, this commit is related with many PR done by @fishy (for example, for the connectivity check), that's why I want to post here and discuss with him before doing anything ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
