Jens-G commented on a change in pull request #2296:
URL: https://github.com/apache/thrift/pull/2296#discussion_r547957019
##########
File path: lib/go/thrift/header_protocol.go
##########
@@ -346,6 +329,13 @@ func (p *THeaderProtocol) Skip(ctx context.Context,
fieldType TType) error {
return p.protocol.Skip(ctx, fieldType)
}
+// SetTConfiguration implemtns TConfigurationSetter.
Review comment:
... implem**e**nts ... (there is more than one instance of this typo)
##########
File path: lib/go/thrift/framed_transport.go
##########
@@ -155,7 +189,7 @@ func (p *TFramedTransport) readFrame() error {
return err
}
size := binary.BigEndian.Uint32(buf)
- if size < 0 || size > p.maxLength {
+ if size < 0 || size > uint32(p.cfg.GetMaxFrameSize()) {
Review comment:
The code was there before but I really wonder when size will become
negative on an uint32?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
