dcelasun commented on pull request #2307: URL: https://github.com/apache/thrift/pull/2307#issuecomment-763409522
Looks reasonable at a first glance, will do a proper review later. I wonder if there are any cases covered by `reflect.DeepEqual` that aren't covered by this method. If there are, that would be a BC break and we'd have to mention it in the changelog. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
