rlerdorf commented on pull request #2288: URL: https://github.com/apache/thrift/pull/2288#issuecomment-772946978
> I went through each the differences in your version to understand and learn from them. Thanks for the expert review. I pulled all of those changes in and added you as a co-author on the squashed commit. Really no need to add me. > One question: what is the notation you used in the name of your `Z4_OBJ_P` macro? In particular, what does the `4` refer to? Just short for the Zend Version which is basically the version for the internal extension API. If you check https://github.com/php/php-src/blob/PHP-8.0/Zend/zend.h you will see it is version 4. PHP 7.,x was version 3. PHP 5.x version 2. And the https://github.com/php/php-src/blob/PHP-8.0/UPGRADING.INTERNALS#L231 doc talks about the changes needed for version 4, although it says "Engine" which isn't really correct. It is the API version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
