fishy commented on a change in pull request #2351:
URL: https://github.com/apache/thrift/pull/2351#discussion_r595253172
##########
File path: lib/go/test/Makefile.am
##########
@@ -85,6 +86,17 @@ gopath: $(THRIFT) $(THRIFTTEST) \
cp -r ./dontexportrwtest gopath/src
touch gopath
+gopathfuzz: $(THRIFT) fuzz/fuzz.go
+ cd fuzz && $(THRIFT) -r --gen go ../../../../tutorial/tutorial.thrift
+ cd fuzz && go mod init fuzz
+ cd fuzz/gen-go/shared && go mod init shared
+ cd fuzz/gen-go/tutorial && go mod init tutorial
+ cd fuzz && go mod edit -replace shared=./gen-go/shared
+ cd fuzz && go mod edit -replace tutorial=./gen-go/tutorial
+ cd fuzz && go mod edit -replace
github.com/apache/thrift/lib/go/thrift=../../../../lib/go/thrift
+ go build fuzz
Review comment:
this line should be `cd fuzz && go build` instead
(does make return to your current directory after every command? I see we
did a lot of `cd fuzz` in the commends but never `cd ..`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
