aaronstgeorge-wf commented on pull request #2366: URL: https://github.com/apache/thrift/pull/2366#issuecomment-810444361
I'm not sure how we could know the size before reading the string. Because this is in the JSON protocol there is no preceding size packed in the data. All you have is the open quote character and you have to read to the end. This check makes sense for compact, binary, et al because they are serialized with the size of the string contained after, but the serialized JSON representation has no such thing. It's just a quote-delimited string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
