emmenlau commented on pull request #2327: URL: https://github.com/apache/thrift/pull/2327#issuecomment-832489384
Would someone be willing to review? I think this PR should be relatively self-contained, so it should not harm the existing functionality. It adds support for Un*x domain sockets on Windows, which can be an interesting use case. For the review, I recommend reviewing the two commits individually. The first one (adding new method `isUnixDomainSocket()`) is a trivial change. The second commit has the functional improvements but is comparably smaller when reviewed individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
