Jens-G commented on pull request #2395: URL: https://github.com/apache/thrift/pull/2395#issuecomment-848331187
I'm not fully convinced. The patch is good, that's not the point. What I am missing is a test case that clearly shows the issue you are reporting. I just added the threadpool server impl to the Test Suite (PR currently building) and ran both the old code and the patched code with a varying set of parameters and clients but I still struggle to reproduce the "dramatic poor performance". Could you elaborate more on that? How can I test that in a possibly simple way? Also, I slightly changed the proposed patch, please find [my version here](https://github.com/Jens-G/thrift/tree/THRIFT-5419). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
