Jens-G commented on a change in pull request #2395:
URL: https://github.com/apache/thrift/pull/2395#discussion_r639269853
##########
File path: lib/netstd/Thrift/Server/TThreadPoolAsyncServer.cs
##########
@@ -218,11 +218,11 @@ public override async Task ServeAsync(CancellationToken
cancellationToken)
/// threadContext will be a TTransport instance
/// </summary>
/// <param name="threadContext"></param>
- private void Execute(object threadContext)
+ private async void ExecuteAsync(TTransport client)
{
Review comment:
`async void` is usually a bad combination that should be avoided (pun
intended)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
