emmenlau commented on pull request #2393:
URL: https://github.com/apache/thrift/pull/2393#issuecomment-855365314


   > If a user is not tolerant to data loss, they should not use UDP. This is 
an option to increase the efficiency of data transfer and avoid blocking the 
main application. A specific example of a use case for this is instrumenting a 
perl application for sending spans to [Jaeger 
agent](https://www.jaegertracing.io/docs/1.22/deployment/#agent), which only 
accepts thrift void-style messages over UDP.
   
   I can very much relate to your use case. But I still worry that from the 
point of view of an unsuspecting Thrift user, its not easily understandable 
that Thrift will allow UDP and then silently drop lost messages. Furthermore, 
for non-void-messages its very likely that this will mess with protocols and 
servers. It seems to me this hands the user a running chainsaw without any 
guidance. But I may not see all the details here, since AFAICS the change is 
"only" in the client? Maybe its less harmful there because users are not able 
to create a corresponding UDP server(?). Opinions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to