bforbis commented on pull request #2393: URL: https://github.com/apache/thrift/pull/2393#issuecomment-855454309
Yes, this would not work for anyone who is using non-void style RPC calls, however considering that UDP is not the default protocol, I find it unlikely this will actually cause any issues for users. Using UDP with thrift should be considered an advanced option and someone who intentionally sets up their client to use UDP should be responsible for understanding the tradeoffs between UDP and TCP and know what they are getting into. As for setting up a UDP server, I specifically don't have a use case for it in perl so did not implement any server side code. In my example, Jaeger Agent is already setup to be a thrift UDP server (presumably that means there is already thrift UDP server support in golang, though I haven't looked closely at the Jaeger codebase to see if they wrote their own custom thrift code). Perhaps I could just leave some documentation in the source file about the use cases for tcp vs udp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
